Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative layout content disappeared when Relative layout has the border with border stroke element. #24841

Merged
merged 42 commits into from
Jan 6, 2025

Conversation

NanthiniMahalingam
Copy link
Contributor

@NanthiniMahalingam NanthiniMahalingam commented Sep 20, 2024

Root cause

• When we set the stroke shape for border, visual element stroke shape is added to the border. Here, handler does not set to the stroke shape element.
• Therefore, IsPlatformEnabled property is set to false for stroke shape of visual element.
• It caused the content disappeared due to update children calculation does not invoked.

Description of changes

  • Skipped IsPlatformEnabled condition checking for shape when adding a stroke shape inside the border because the handler for the stroke shape element was not set.

Validated the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Issues Fixed:
Fixes #23934

Output images:
Windows platform:
Before changes:
image

After changes:
Windows_AfterChanges

Android
Before changes:
Android_BeforeChanges

After changes:

Android_AfterChanges

iOS
Before changes:
iOS_BeforeChanges

After changes:

iOS_AfterChanges

macOS
Before changes:
macOS_BeforeChanges

After changes:
macOS_AfterChanges

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Sep 20, 2024
@rmarinho
Copy link
Member

rmarinho commented Sep 20, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@NanthiniMahalingam NanthiniMahalingam marked this pull request as ready for review October 8, 2024 11:24
@NanthiniMahalingam NanthiniMahalingam requested a review from a team as a code owner October 8, 2024 11:24
@rmarinho
Copy link
Member

rmarinho commented Oct 8, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@NanthiniMahalingam
Copy link
Contributor Author

Hi @PureWeen

Where is this check happening?

• Therefore, IsPlatformEnabled property is set to false for stroke shape of visual element.

I'm wondering if we can resolve this issue without needing to call ToPlatform on the shapeviews

We have modified the fix without the need to call the ToPlatform method on the shape view. Could you please verify once?

@jsuarezruiz

This comment was marked as outdated.

This comment was marked as outdated.

@PureWeen PureWeen added this to the .NET 9 SR1 milestone Oct 23, 2024
@jsuarezruiz

This comment was marked as outdated.

This comment was marked as outdated.

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Oct 28, 2024

/azp run

This comment was marked as outdated.

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only happens with RelativeLayout or with all the legacy layouts?

@NanthiniMahalingam
Copy link
Contributor Author

Only happens with RelativeLayout or with all the legacy layouts?

Hi @jsuarezruiz ,
The issue occurs with all legacy layouts.

@jsuarezruiz jsuarezruiz removed their assignment Nov 4, 2024
@PureWeen PureWeen modified the milestones: .NET 9 SR1, .NET 9 SR2 Nov 5, 2024
@PureWeen PureWeen modified the milestones: .NET 9 SR2, .NET 9 SR3 Nov 27, 2024
@sheiksyedm sheiksyedm added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 6, 2024
@jfversluis jfversluis added the area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter label Dec 11, 2024
@rmarinho rmarinho requested a review from PureWeen December 18, 2024 14:06
@PureWeen PureWeen merged commit 1778f54 into dotnet:main Jan 6, 2025
107 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/android 🤖 platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst platform/windows 🪟
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

When the Border control is in RelativeLayout, RelativeLayout is not work correctly from 8.0.60 SR6
7 participants