Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Ensure images in buttons never scale up, only down #21463

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

Foda
Copy link
Member

@Foda Foda commented Mar 26, 2024

Description of Change

Ensure images in buttons never scale up, only down, by setting the max height of images to the source BitmapImage (scaled by display density).

Issues Fixed

CC: Windows version of #20953

@Foda Foda requested review from PureWeen and tj-devel709 March 26, 2024 19:03
@Foda Foda requested a review from a team as a code owner March 26, 2024 19:03
@dotnet-policy-service dotnet-policy-service bot added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Mar 26, 2024
jsuarezruiz
jsuarezruiz previously approved these changes Mar 27, 2024
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge over TJ's tests into this PR and generate images for his same scenarios?

Ensure source is set after image opened event is subscribed to
@PureWeen PureWeen enabled auto-merge (squash) March 27, 2024 23:31
@PureWeen PureWeen merged commit dab9920 into main Mar 28, 2024
47 checks passed
@PureWeen PureWeen deleted the foda/buttonmk2 branch March 28, 2024 01:47
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants