Bump to Xcode 9 #2176
Merged
Bump to Xcode 9 #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Versions-ios and Versions-mac file too.
dalexsoto
requested changes
Jun 5, 2017
Make.config
Outdated
| XCODE_DEVELOPER_ROOT=/Applications/Xcode83.app/Contents/Developer | ||
| # Xcode 9 | ||
| XCODE_VERSION=9 | ||
| XCODE_URL=http://xamarin-storage/bot-provisioning/Xcode_9.xip |
There was a problem hiding this comment.
I think you meant http://xamarin-storage/bot-provisioning/Xcode_9_beta.xip
There was a problem hiding this comment.
Just assumed the wrong link (:
|
Build failure |
1 similar comment
|
Build failure |
spouliot
approved these changes
Jun 5, 2017
|
Please review failures and post them on slack, if help is needed, until the branch builds :) |
|
Build failure |
…t#2095)" This reverts commit 425274a. Prevents building xcode9 branch, see: https://jenkins.mono-project.com/job/xamarin-macios-pr-builder/3886/console ``` runtime.m:1122:9: error: cannot initialize a variable of type 'char *' with an rvalue of type 'const char *' char *last_sep = strrchr (info.dli_fname, '/'); ```
dotnet#2095)"" This reverts commit 27e292e.
…rvalue of type 'const char *' Prevented building xcode9 branch, see: https://jenkins.mono-project.com/job/xamarin-macios-pr-builder/3886/console ``` runtime.m:1122:9: error: cannot initialize a variable of type 'char *' with an rvalue of type 'const char *' char *last_sep = strrchr (info.dli_fname, '/'); ```
|
Don't merge, I will do a force push at the end to refactor the commits (I don't think we should just squash them this time). Will do this once it's a. building and b. approved. |
|
Build failure |
1 similar comment
|
Build failure |
The generated output doesn't compile because Apple forgot to ship headers for the ExternalAccessory framework in their tvOS simulator SDK.
rolfbjarne
approved these changes
Jun 6, 2017
spouliot
approved these changes
Jun 6, 2017
|
After 3 hr 12 min the build seems stuck but we can build locally with these fixes. Slack conversation: So let's squash merge this so people can indeed build (: |
|
Build failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Versions-ios and Versions-mac file too.