[msbuild] Don't add frameworks with static libraries to Hot Restart apps. #19300

rolfbjarne · 2023-10-23T14:28:44Z

The main problem is that an app with unsigned executable code will fail any signing
verification, and the app won't install on device.

This is implemented by doing two changes:

Augment the FilterStaticFrameworks task to only filter out frameworks with
static libraries (and thus keeping everything that's not a static framework, even
if it's not even a framework).
Execute the FilterStaticFrameworks task to filter out static frameworks from
the entire list of files to bundle in the hot restart app bundle.

…pps. The main problem is that an app with unsigned executable code will fail any signing verification, and the app won't install on device. This is implemented by doing two changes: 1. Augment the FilterStaticFrameworks task to only filter out frameworks with static libraries (and thus keeping everything that's not a static framework, even if it's not even a framework). 2. Execute the FilterStaticFrameworks task to filter out static frameworks from the entire list of files to bundle in the hot restart app bundle.

emaf · 2023-10-23T15:30:02Z

msbuild/Xamarin.MacDev.Tasks/Tasks/FilterStaticFrameworksTaskBase.cs

@@ -32,6 +34,11 @@ public override bool Execute ()
 							continue;
 						}

+						if (OnlyFilterFrameworks && !Path.GetDirectoryName (frameworkExecutablePath).EndsWith (".framework", StringComparison.OrdinalIgnoreCase)) {
+							Log.LogMessage (MessageImportance.Low, $"Skipped processing {item.ItemSpec} because it's not a framework");


I wonder if this should be logged as a warning instead. I know it could be annoying, but if we are choosing to ignore/skip static libraries, it means those are not supported in the current context.
And a warning could be a hint for crashes that may happen because those were not included in the app bundle?

We already log a warning for static libraries we skip, this is logging all the other files this task just skips (i.e. don't filter out, so they'll end up in the app bundle).

…ies)

vs-mobiletools-engineering-service2 · 2023-10-23T22:41:55Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: c70b9786025bafba2c238be71913daf2cc68b46a [PR build]

vs-mobiletools-engineering-service2 · 2023-10-23T22:55:00Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-23T23:18:57Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-23T23:21:16Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-23T23:46:09Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: c70b9786025bafba2c238be71913daf2cc68b46a [PR build]

vs-mobiletools-engineering-service2 · 2023-10-24T01:12:44Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 235 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 41 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: c70b9786025bafba2c238be71913daf2cc68b46a [PR build]

rolfbjarne · 2023-10-25T06:46:13Z

/sudo backport release/8.0.1xx

vs-mobiletools-engineering-service2 · 2023-10-25T06:46:45Z

Backport Job to branch release/8.0.1xx Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-10-25T06:48:32Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8590477 for more details.

…s to Hot Restart apps. (#19336) The main problem is that an app with unsigned executable code will fail any signing verification, and the app won't install on device. This is implemented by doing two changes: 1. Augment the FilterStaticFrameworks task to only filter out frameworks with static libraries (and thus keeping everything that's not a static framework, even if it's not even a framework). 2. Execute the FilterStaticFrameworks task to filter out static frameworks from the entire list of files to bundle in the hot restart app bundle. Backport of #19300 --------- Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

rolfbjarne requested review from emaf and mauroa as code owners October 23, 2023 14:28

This comment has been minimized.

Sign in to view

emaf reviewed Oct 23, 2023

View reviewed changes

emaf approved these changes Oct 23, 2023

View reviewed changes

mauroa approved these changes Oct 23, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

Fix assembly name.

61f09b6

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Oct 23, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

Skip before checking for file existence (which will fail for director…

c70b978

…ies)

mandel-macaque approved these changes Oct 23, 2023

View reviewed changes

rolfbjarne merged commit bb465c3 into dotnet:main Oct 25, 2023

rolfbjarne deleted the hotrestart-filter-static-frameworks branch October 25, 2023 06:46

vs-mobiletools-engineering-service2 mentioned this pull request Oct 25, 2023

[release/8.0.1xx] [msbuild] Don't add frameworks with static libraries to Hot Restart apps. #19336

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[msbuild] Don't add frameworks with static libraries to Hot Restart apps. #19300

[msbuild] Don't add frameworks with static libraries to Hot Restart apps. #19300

rolfbjarne commented Oct 23, 2023

This comment has been minimized.

emaf Oct 23, 2023

rolfbjarne Oct 23, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 23, 2023

vs-mobiletools-engineering-service2 commented Oct 23, 2023

vs-mobiletools-engineering-service2 commented Oct 23, 2023

vs-mobiletools-engineering-service2 commented Oct 23, 2023

vs-mobiletools-engineering-service2 commented Oct 23, 2023

vs-mobiletools-engineering-service2 commented Oct 24, 2023

rolfbjarne commented Oct 25, 2023

vs-mobiletools-engineering-service2 commented Oct 25, 2023

vs-mobiletools-engineering-service2 commented Oct 25, 2023

[msbuild] Don't add frameworks with static libraries to Hot Restart apps. #19300

[msbuild] Don't add frameworks with static libraries to Hot Restart apps. #19300

Conversation

rolfbjarne commented Oct 23, 2023

This comment has been minimized.

emaf Oct 23, 2023

Choose a reason for hiding this comment

rolfbjarne Oct 23, 2023

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 23, 2023

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Oct 23, 2023

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Oct 23, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

vs-mobiletools-engineering-service2 commented Oct 23, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

vs-mobiletools-engineering-service2 commented Oct 23, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Oct 24, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts

rolfbjarne commented Oct 25, 2023

vs-mobiletools-engineering-service2 commented Oct 25, 2023

vs-mobiletools-engineering-service2 commented Oct 25, 2023