nameof calls should not warn on analyzer #2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ber and instead will be translated to load an string Add tests Fix ExpectedWarnings from disabled intrinsics that were producing warnings from accessing fields in a nameof call
vitek-karas
approved these changes
Feb 24, 2022
|
I'm going to merge this as it unblocks some of the work on the intrinsics (or makes it easier) |
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
…ber and instead will be translated to load an string (dotnet/linker#2649) Add tests Fix ExpectedWarnings from disabled intrinsics that were producing warnings from accessing fields in a nameof call Commit migrated from dotnet/linker@6a82f4f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a condition to bypass
nameofusage since it will not invoke the member and instead will be translated to load a stringAdd tests
Fix ExpectedWarnings from disabled intrinsics that were producing warnings from accessing fields in a
nameofcallFixes #2647