TestConsole supporting parallel execution #17993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ No release notes required |
majocha
commented
Nov 12, 2024
majocha
commented
Nov 12, 2024
majocha
commented
Nov 12, 2024
tests/FSharp.Compiler.Private.Scripting.UnitTests/DependencyManagerInteractiveTests.fs
Show resolved
Hide resolved
majocha
commented
Nov 12, 2024
majocha
commented
Nov 12, 2024
majocha
commented
Nov 13, 2024
T-Gro
reviewed
Nov 13, 2024
T-Gro
reviewed
Nov 13, 2024
T-Gro
reviewed
Nov 13, 2024
T-Gro
reviewed
Nov 13, 2024
T-Gro
reviewed
Nov 13, 2024
T-Gro
reviewed
Nov 13, 2024
T-Gro
reviewed
Nov 13, 2024
|
I like this. I don't know why end2end tests are failing, but it looks like they are getting the wrong sdk. |
T-Gro
approved these changes
Nov 13, 2024
|
This is really nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of FSharp.Test.Utilities to use thread-safe console redirection and output capture.
The problem this solves looks like this:
Quite a few test cases redirect stdout and stderr to capture console output.
Console.Outbeing a global resource makes it impossible to run them concurrently, they would either hijack the redirected streams from each other or write to the wrong redirected stream.This PR introduces
TestConsole. At the beginning of a test run it installs redirecting streams that isolate access to console for each concurrently running test case. It is implemented usingAsyncLocal.This PR does not yet enable actual parallel execution of tests.