[release/9.0] Return null when the type is nullable for Cosmos Max/Min/Average #35216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Return null when the type is nullable for Cosmos Max/Min/Average Fixes #35094 This was a regression resulting from the major Cosmos query refactoring that happened in EF9. In EF8, the functions Min, Max, and Average would return null if the return type was nullable or was cast to a nullable when the collection is empty. In EF9, this started throwing, which is correct for non-nullable types, but a regression for nullable types. * Added notes
ajcvickers
changed the title
roji
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #35173
Fixes #35094
Description
Updates to the Cosmos query architecture regressed translation for aggregate functions where the return type is nullable.
Customer impact
Cosmos queries that use
Min,Max, orAverageand return a nullable type throw in EF8 if the set is empty. This is the correct behavior for non-nullable returns, but if possible we instead return null, which is a more useful behavior, aligns with relational, and is the behavior we had in EF8.How found
Customer reported on 9.
Regression
Yes, from 8.
Testing
Existing tests fixes and new tests added.
Risk
Low and quirked.