Map directly to JSON id for types converted to string #34564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ajcvickers
force-pushed
the
ThePerfectStringAlong
branch
from
e115400 to
f79c7d7
Compare
| { | ||
| jsonIdProperty.Builder.ToJsonProperty(null); | ||
| entityType.Builder.HasNoProperty(jsonIdProperty); |
There was a problem hiding this comment.
entityType.Builder.RemoveUnusedImplicitProperties([jsonIdProperty]);
| } | ||
|
|
||
| if (computedIdProperty != null | ||
| if (computedIdProperty is not null | ||
| && computedIdProperty != jsonIdProperty) | ||
| { | ||
| entityType.Builder.HasNoProperty(computedIdProperty); |
There was a problem hiding this comment.
entityType.Builder.RemoveUnusedImplicitProperties([computedIdProperty]);
AndriySvyryd
approved these changes
Aug 30, 2024
ajcvickers
force-pushed
the
ThePerfectStringAlong
branch
from
f79c7d7 to
cb1d795
Compare
ajcvickers
force-pushed
the
ThePerfectStringAlong
branch
from
cb1d795 to
662b616
Compare
ajcvickers
added a commit
that referenced
this pull request
Aug 30, 2024
* Map directly to JSON id for types converted to string Fixes #34554 I also needed to fix #34511 to make this work. This was happening because we were removing the by-convention property added by property discovery. We only need to remove it when it's the computed property as well, which is handled by the other case. * Updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34554
I also needed to fix #34511 to make this work. This was happening because we were removing the by-convention property added by property discovery. We only need to remove it when it's the computed property as well, which is handled by the other case.