-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from dotnet/runtime #31421
[main] Update dependencies from dotnet/runtime #31421
Conversation
…0806.6 Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Logging , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , System.Text.Json From Version 8.0.0-rc.1.23402.2 -> To Version 8.0.0-rc.1.23406.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approving dependency update.
ptal @dotnet/interop-contrib |
…0814.1 Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Logging , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , System.Text.Json From Version 8.0.0-rc.1.23402.2 -> To Version 8.0.0-rc.1.23414.1
@dotnet/dnr-codeflow @dotnet/efteam I don't know who decides on the compiler version but I believe this needs to be resolved for a coherent build? cc @mmitche |
For Microsoft's builds, there is no coherency requirement for the compiler/sdk. For source build (of which efcore is not involved), the installer repo determines what gets used. This repo should upgrade its SDK to match runtime's. |
@mmitche this repo is already using a later SDK than runtime, and downgrading to match doesn't help. efcore: 8.0.100-rc.1.23381.2 Changing |
Sorry, it's the version of roslyn in the SDK that matters. Runtime upgraded roslyn outside of the SDK: /~https://github.com/dotnet/runtime/blame/main/eng/Versions.props#L43 However, I would try a newer SDK, e.g. 8.0.100-rc.1.23416.11 which should carry a new enough roslyn. |
8.0.100-rc.1.23416.11 didn't help, it just changed the error message from recommending 'preview' to '12.0', and updating to version 12 changed the error message to say use 'in'. Updating the SDK also introduced other Aot errors so I won't go there right now, just changing 'ref' to 'in' seems to work and be required regardless. |
@tannergooding For review of the ref->in change. |
yeah this was dotnet/runtime#89736 |
This pull request updates the following dependencies
From /~https://github.com/dotnet/runtime