Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/runtime #31421

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 7, 2023

This pull request updates the following dependencies

From /~https://github.com/dotnet/runtime

  • Subscription: daf314a8-d8c8-4b54-8dcc-08d82e674dfc
  • Build: 20230814.1
  • Date Produced: August 14, 2023 10:35:21 AM UTC
  • Commit: 8986374ea73f1e5b1977dd0058fbdf591936408a
  • Branch: refs/heads/main

…0806.6

Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Logging , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , System.Text.Json
 From Version 8.0.0-rc.1.23402.2 -> To Version 8.0.0-rc.1.23406.6
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@lewing
Copy link
Member

lewing commented Aug 13, 2023

ptal @dotnet/interop-contrib

…0814.1

Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Logging , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , System.Text.Json
 From Version 8.0.0-rc.1.23402.2 -> To Version 8.0.0-rc.1.23414.1
@lewing
Copy link
Member

lewing commented Aug 14, 2023

@dotnet/dnr-codeflow @dotnet/efteam I don't know who decides on the compiler version but I believe this needs to be resolved for a coherent build?

cc @mmitche

@mmitche
Copy link
Member

mmitche commented Aug 15, 2023

@dotnet/dnr-codeflow @dotnet/efteam I don't know who decides on the compiler version but I believe this needs to be resolved for a coherent build?

cc @mmitche

For Microsoft's builds, there is no coherency requirement for the compiler/sdk. For source build (of which efcore is not involved), the installer repo determines what gets used. This repo should upgrade its SDK to match runtime's.

@Tratcher
Copy link
Member

@mmitche this repo is already using a later SDK than runtime, and downgrading to match doesn't help.

efcore: 8.0.100-rc.1.23381.2
runtime: 8.0.100-preview.7.23376.3

Changing ref to in here seems to have fixed it.

@mmitche
Copy link
Member

mmitche commented Aug 16, 2023

Sorry, it's the version of roslyn in the SDK that matters. Runtime upgraded roslyn outside of the SDK: /~https://github.com/dotnet/runtime/blame/main/eng/Versions.props#L43

However, I would try a newer SDK, e.g. 8.0.100-rc.1.23416.11 which should carry a new enough roslyn.

@Tratcher
Copy link
Member

Tratcher commented Aug 16, 2023

8.0.100-rc.1.23416.11 didn't help, it just changed the error message from recommending 'preview' to '12.0', and updating to version 12 changed the error message to say use 'in'.

Updating the SDK also introduced other Aot errors so I won't go there right now, just changing 'ref' to 'in' seems to work and be required regardless.

@mmitche
Copy link
Member

mmitche commented Aug 16, 2023

8.0.100-rc.1.23416.11 didn't help, it just changed the error message from recommending 'preview' to '12.0', and updating to version 12 changed the error message to say use 'in'.

Updating the SDK also introduced other Aot errors so I won't go there right now, just changing 'ref' to 'in' seems to work.

@tannergooding For review of the ref->in change.

@lewing
Copy link
Member

lewing commented Aug 16, 2023

@mmitche this repo is already using a later SDK than runtime, and downgrading to match doesn't help.

efcore: 8.0.100-rc.1.23381.2 runtime: 8.0.100-preview.7.23376.3

Changing ref to in here seems to have fixed it.

yeah this was dotnet/runtime#89736

@lewing lewing requested a review from tannergooding August 16, 2023 23:55
@dotnet-maestro dotnet-maestro bot merged commit 697a12b into main Aug 17, 2023
@dotnet-maestro dotnet-maestro bot deleted the darc-main-49e9ae75-dcfc-4eca-81b1-d8c7924634fd branch August 17, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants