Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: related to #8653 #8658

Merged
merged 1 commit into from
Apr 20, 2023
Merged

fix: related to #8653 #8658

merged 1 commit into from
Apr 20, 2023

Conversation

VaclavElias
Copy link
Contributor

This is a follow up issue. With this fix, docfx generates docs. I hope it is not going to cause any side effects.

Also fixes #8653

try
{
var result = language switch
{
SyntaxLanguage.VB => VB.SymbolDisplay.ToDisplayParts(symbol, format),
_ => CS.SymbolDisplay.ToDisplayParts(symbol, format),
};
if (overload && language is SyntaxLanguage.CSharp && symbol.IsCastOperator())
return GetCastOperatorOverloadDisplayParts(result);
return result;
}
catch
{
return ImmutableArray<SymbolDisplayPart>.Empty;
}

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (7831dfa) 76.74% compared to head (6702005) 76.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8658      +/-   ##
==========================================
- Coverage   76.74%   76.74%   -0.01%     
==========================================
  Files         607      607              
  Lines       25054    25057       +3     
==========================================
+ Hits        19228    19230       +2     
- Misses       5826     5827       +1     
Impacted Files Coverage Δ
...crosoft.DocAsCode.Dotnet/SymbolFormatter.Syntax.cs 97.18% <100.00%> (+0.03%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih merged commit bdcf8fd into dotnet:main Apr 20, 2023
@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Apr 24, 2023
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 🪲 - Object reference not set to an instance of an object
2 participants