Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: verify compilation diagnostics #8397

Merged
merged 7 commits into from
Feb 8, 2023
Merged

feat: verify compilation diagnostics #8397

merged 7 commits into from
Feb 8, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Feb 7, 2023

A lot of .NET API docs problems are caused by a bad compilation. This PR adds compilation diagnostics logging and abort on compilation errors.

Fixes #2387

@yufeih yufeih force-pushed the verify-compilation branch from 2735580 to dc3c74f Compare February 7, 2023 13:35
@yufeih yufeih changed the title feat: log compilation diagnostics fix: reference assembly not loaded Feb 7, 2023
@yufeih yufeih force-pushed the verify-compilation branch from 348fe2f to dc3c74f Compare February 8, 2023 05:59
@yufeih yufeih changed the title fix: reference assembly not loaded feat: log compilation diagnostics Feb 8, 2023
@yufeih yufeih changed the title feat: log compilation diagnostics feat: verify compilation diagnostics Feb 8, 2023
@yufeih yufeih marked this pull request as ready for review February 8, 2023 09:30
@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Feb 8, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 76.89% // Head: 76.91% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (68ecae6) compared to base (526cd74).
Patch coverage: 92.45% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8397      +/-   ##
==========================================
+ Coverage   76.89%   76.91%   +0.01%     
==========================================
  Files         866      866              
  Lines       30928    30919       -9     
==========================================
- Hits        23781    23780       -1     
+ Misses       7147     7139       -8     
Impacted Files Coverage Δ
...oft.DocAsCode.Common/Loggers/ConsoleLogListener.cs 80.76% <ø> (-3.85%) ⬇️
src/Microsoft.DocAsCode.Common/Loggers/Logger.cs 67.01% <ø> (ø)
...e.Dotnet/ExtractMetadata/ExtractMetadataOptions.cs 100.00% <ø> (ø)
...de.Dotnet/ExtractMetadata/ExtractMetadataWorker.cs 79.66% <90.00%> (+0.59%) ⬆️
...rc/Microsoft.DocAsCode.Dotnet/CompilationHelper.cs 95.55% <94.33%> (ø)
...actMetadata/RoslynIntermediateMetadataExtractor.cs 100.00% <100.00%> (ø)
....DocAsCode.Dotnet/Visitors/SymbolVisitorAdapter.cs 94.84% <100.00%> (ø)
src/Microsoft.DocAsCode.Common/Git/GitUtility.cs 74.46% <0.00%> (-0.54%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih force-pushed the verify-compilation branch from 9ea12d4 to c49c809 Compare February 8, 2023 09:59
@yufeih yufeih force-pushed the verify-compilation branch from 092312d to a671f0b Compare February 8, 2023 10:04
@yufeih yufeih merged commit 177a751 into main Feb 8, 2023
@yufeih yufeih deleted the verify-compilation branch February 8, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong metadata generation for Netstandard assemblies
1 participant