Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: projects in sln build twice #8386

Merged
merged 1 commit into from
Feb 3, 2023
Merged

fix: projects in sln build twice #8386

merged 1 commit into from
Feb 3, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Feb 2, 2023

OpenSolutionAsync method triggers an MSBuild batch build for all projects in the solution, causing each project to build twice. Switch to SolutionFile.Parse to parse project list from .sln.

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Feb 2, 2023
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 76.26% // Head: 76.26% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (558ce6c) compared to base (87a9ee9).
Patch coverage: 71.42% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8386      +/-   ##
==========================================
- Coverage   76.26%   76.26%   -0.01%     
==========================================
  Files         885      885              
  Lines       31791    31780      -11     
==========================================
- Hits        24246    24236      -10     
+ Misses       7545     7544       -1     
Impacted Files Coverage Δ
src/Microsoft.DocAsCode.Dotnet/FileInformation.cs 85.71% <ø> (ø)
...de.Dotnet/ExtractMetadata/ExtractMetadataWorker.cs 73.64% <71.42%> (-0.22%) ⬇️
src/Microsoft.DocAsCode.Common/Git/GitUtility.cs 74.46% <0.00%> (-0.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih merged commit 8040cb2 into main Feb 3, 2023
@yufeih yufeih deleted the parse-solution branch February 3, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants