Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix locale option for continue-build #7642

Merged
merged 3 commits into from
Sep 28, 2021

Conversation

AngryBerryMS
Copy link
Member

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #7642 (232d67d) into v3 (d663a3c) will decrease coverage by 2.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3    #7642      +/-   ##
==========================================
- Coverage   85.12%   82.83%   -2.30%     
==========================================
  Files         379      379              
  Lines       15050    15052       +2     
  Branches     2871     2871              
==========================================
- Hits        12811    12468     -343     
- Misses       1629     1997     +368     
+ Partials      610      587      -23     
Impacted Files Coverage Δ
src/docfx/cli/Docfx.cs 50.30% <100.00%> (+0.61%) ⬆️
...Docs.Build.Specialized/template/LandingDataMenu.cs 0.00% <0.00%> (-100.00%) ⬇️
...s.Build.Specialized/learn/Models/LegacyManifest.cs 0.00% <0.00%> (-100.00%) ⬇️
....Build.Specialized/template/LandingDataAbstract.cs 0.00% <0.00%> (-100.00%) ⬇️
....Build.Specialized/template/LandingDataMenuItem.cs 0.00% <0.00%> (-100.00%) ⬇️
...uild.Specialized/learn/Models/UnitValidateModel.cs 0.00% <0.00%> (-100.00%) ⬇️
...ild.Specialized/learn/Models/LegacyManifestItem.cs 0.00% <0.00%> (-100.00%) ⬇️
...d.Specialized/learn/Models/LegacyManifestOutput.cs 0.00% <0.00%> (-100.00%) ⬇️
...ecialized/learn/Models/LegacyManifestOutputItem.cs 0.00% <0.00%> (-100.00%) ⬇️
...icrosoft.Docs.Build.Specialized/learn/Validator.cs 0.00% <0.00%> (-93.03%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d663a3c...232d67d. Read the comment docs.

@opbld41
Copy link

opbld41 commented Sep 27, 2021

powerbi-docs-pr.de-DE(00:00:06.8214116)
diff --git "a/D:/docfx.TestData\\regression-test.powerbi-docs-pr.de-DE\\output/.errors.log" "b/D:/docfx.TestData\\regression-test.powerbi-docs-pr.de-DE\\.temp/.errors.log"
index 5ae2581..f2f13dc 100644
--- "a/D:/docfx.TestData\\regression-test.powerbi-docs-pr.de-DE\\output/.errors.log"
+++ "b/D:/docfx.TestData\\regression-test.powerbi-docs-pr.de-DE\\.temp/.errors.log"
@@ -1,7 +1,7 @@
 {
   "message_severity": "info",
   "code": "MetadataValidationRuleset",
-  "message": "Metadata validation ruleset used: _localization_.",
+  "message": "Metadata validation ruleset used: DevRelations.",
   "line": 0,
   "end_line": 0,
   "column": 0,

@opbld41
Copy link

opbld41 commented Sep 27, 2021

🧭azure-docs-pr(00:01:51.7814246 | exceed 100s)
 25% | Microsoft.Docs.MarkdigExtensions!Microsoft.Docs.MarkdigExtensions.ResolveLinkExtension.UpdateLinks(class Markdig.Syntax.MarkdownObject)
 25% | docfx!Microsoft.Docs.Build.ParallelUtility+<>c__DisplayClass2_0`1[System.__Canon].<ForEach>b__0(!0)
 20% | docfx!Microsoft.Docs.Build.DocsetBuilder+<>c__DisplayClass42_1.<Build>b__17(class Microsoft.Docs.Build.FilePath)
 18% | docfx!Microsoft.Docs.Build.PageBuilder.Build(class Microsoft.Docs.Build.ErrorBuilder,class Microsoft.Docs.Build.FilePath)
 15% | docfx!Microsoft.Docs.Build.PageBuilder.LoadMarkdown(class Microsoft.Docs.Build.ErrorBuilder,class Microsoft.Docs.Build.FilePath)
 14% | docfx!Microsoft.Docs.Build.Output+<>c__DisplayClass7_0.<WriteJson>b__0()
 13% | docfx!Microsoft.Docs.Build.MarkdownEngine.ToHtml(class Microsoft.Docs.Build.ErrorBuilder,class System.String,class Microsoft.Docs.Build.SourceInfo,value class Microsoft.Docs.Build.MarkdownPipelineType,class Microsoft.Docs.Build.ConceptualModel,bool)
 12% | Markdig!Markdig.Markdown.ToHtml(class System.String,class Markdig.MarkdownPipeline)
  9% | Markdig!Markdig.Parsers.MarkdownParser.Parse()
  8% | Markdig!Markdig.Renderers.RendererBase.Write(class Markdig.Syntax.MarkdownObject)
  6% | Newtonsoft.Json!Newtonsoft.Json.JsonSerializer.SerializeInternal(class Newtonsoft.Json.JsonWriter,class System.Object,class System.Type)
  6% | docfx!Microsoft.Docs.Build.Docfx+<>c__DisplayClass6_0.<CreateCommand>b__0(class Microsoft.Docs.Build.CommandLineOptions)
  5% | docfx!Microsoft.Docs.Build.Docfx+<>c__DisplayClass4_0.<BuildCommand>b__0(class Microsoft.Docs.Build.CommandLineOptions)
  5% | Newtonsoft.Json!Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.Serialize(class Newtonsoft.Json.JsonWriter,class System.Object,class System.Type)
  5% | docfx!Microsoft.Docs.Build.Builder.Run(class Microsoft.Docs.Build.CommandLineOptions,class Microsoft.Docs.Build.Package)
  5% | docfx!Microsoft.Docs.Build.Builder.Build(class Microsoft.Docs.Build.ErrorBuilder,class System.IProgress`1<class System.String>,class System.String[])
  5% | docfx!Microsoft.Docs.Build.Watcher.Write(class System.Action)
  5% | docfx!Microsoft.Docs.Build.LinkResolver.ResolveLink(value class Microsoft.Docs.Build.SourceInfo`1<class System.String>,class Microsoft.Docs.Build.FilePath,class Microsoft.Docs.Build.FilePath,class Microsoft.Docs.Validation.LinkNode)
  5% | docfx!Microsoft.Docs.Build.MarkdownEngine.GetLink(class Microsoft.Docs.Build.LinkInfo)
  5% | Newtonsoft.Json!Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.SerializeObject(class Newtonsoft.Json.JsonWriter,class System.Object,class Newtonsoft.Json.Serialization.JsonObjectContract,class Newtonsoft.Json.Serialization.JsonProperty,class Newtonsoft.Json.Serialization.JsonContainerContract,class Newtonsoft.Json.Serialization.JsonProperty)
  4% | docfx!Microsoft.Docs.Build.ErrorBuilder.AddRange(class System.Collections.Generic.IEnumerable`1<class Microsoft.Docs.Build.Error>)
  4% | docfx!Microsoft.Docs.Build.LinkResolver.TryResolveAbsoluteLink(value class Microsoft.Docs.Build.SourceInfo`1<class System.String>,class Microsoft.Docs.Build.FilePath,class Microsoft.Docs.Build.FilePath,class Microsoft.Docs.Validation.LinkNode)
  4% | docfx!Microsoft.Docs.Build.MarkdownEngine.GetImageLink(class System.String,class Markdig.Syntax.MarkdownObject,class System.String,class System.String)
  4% | Newtonsoft.Json!Newtonsoft.Json.Linq.JObject.WriteTo(class Newtonsoft.Json.JsonWriter,class Newtonsoft.Json.JsonConverter[])
  3% | Markdig!Markdig.Renderers.RendererBase.WriteChildren(class Markdig.Syntax.ContainerBlock)
  3% | docfx!Microsoft.Docs.Build.ErrorLog.Add(class Microsoft.Docs.Build.Error)
  3% | docfx!Microsoft.Docs.Build.ContentValidator.ValidateLink(class Microsoft.Docs.Build.FilePath,class Microsoft.Docs.Validation.LinkNode)
  3% | docfx!Microsoft.Docs.Build.MarkdigUtility.<Replace>g__ReplaceCore|7_0(class Markdig.Syntax.MarkdownObject,class System.Func`2<class Markdig.Syntax.MarkdownObject,class Markdig.Syntax.MarkdownObject>)
  3% | Newtonsoft.Json!Newtonsoft.Json.JsonTextWriter.WriteEscapedString(class System.String,bool)
  3% | docfx!Microsoft.Docs.Build.Builder+<>c__DisplayClass8_0.<Build>b__0(class Microsoft.Docs.Build.DocsetBuilder)

@yufeih yufeih merged commit 2986548 into dotnet:v3 Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants