Metrics Design #211
Metrics Design #211
Conversation
|
CC @noahfalk |
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
|
|
||
| ## Overview | ||
|
|
||
| This document is discussing the .NET Metrics APIs design which implements the [OpenTelemetry specification](/~https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md). |
There was a problem hiding this comment.
How should I think about these APIs vs the DiagnosticCounter APIs we've been using from System.Diagnostics.Tracing? When does someone choose these vs EventCounter, PollingCounter, etc.?
There was a problem hiding this comment.
We already working on doing the needed work and publishing the guide for the users currently using EventCounters. That include, having the tools like dotnet-counters work with new Metrics, migrating from EventCounter to Metrics, and allow migrated libraries/apps from EventCounters to Metrics to implement a small shim for any app compat support if necessary. We should be able to do that during .NET 6.0 release.
There was a problem hiding this comment.
Does that mean we're deprecating DiagnosticCounter, changing all of our existing DiagnosticCounters to be based on these new APIs, etc.? I'm confused. It's strange that we just released those APIs in the last version or two, and now it seems we're saying they're obsolete.
There was a problem hiding this comment.
We'll recommend using Metrics moving forward but we are not deprecating the Event counters in this release at least.
There was a problem hiding this comment.
So I hope then we're replacing our own usage in .NET 6?
dotnet/runtime#44445