-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update windows license information #9562
Conversation
There is more offline discussion about this |
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The following binaries are licensed with the | ||
[.NET Library License](https://dotnet.microsoft.com/dotnet_library_license.htm) | ||
|
||
* coreclr.dll and .NET runtimes included in binaries published as single-file (due to [extra telemetry](/~https://github.com/dotnet/runtime/blob/main/src/coreclr/vm/dwreport.cpp) included by .NET runtime in Windows Error Reporting crash reports) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? The linked dwreport.cpp
file seems to be MIT-licensed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code itself is MIT. The resultant binary is licensed as .NET Library license because of data collection, per the comment. .NET app crashes on Windows generate memory dumps that get collected by Watson. Those dumps are used to fix bugs in .NET. Many Microsoft products are integrated with Watson. I don't know how many product fixes are made based on Watson information but it has to be a lot. .NET Framework is the same.
There is a clause in the .NET Library License about data collection. The .NET SDK is the other component that I'm aware of that relies on this clause. One can certainly imagine using MIT with software that has a data collection scenario. We decided not to do that.
I remember using Office when I was a kid and seeing the "Dr. Watson" dialog. Yes, Sherlock Holmes themed. Office was the originator of Watson.
Contributes to: dotnet/runtime#108905
We were given the guidance that the license we were using for
vcruntime140_cor3.dll
was wrong and that we could use ".NET Library License" instead for it.I also took the liberty to do some cleanup to make this document easier to read.
We can merge when @jkotas approves.