[release/9.0] Harden schema reference transformer for relative references #59779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Harden schema reference transformer for relative references * Apply suggestions from code review Co-authored-by: Brennan <brecon@microsoft.com> * Remove uneeded setting * One more cleanup * Check for top-level schemas in tests --------- Co-authored-by: Brennan <brecon@microsoft.com>
dotnet-issue-labeler
bot
added
the
area-infrastructure
captainsafia
changed the title
captainsafia
added
Servicing-consider
captainsafia
added
Servicing-approved
|
Approved via email. |
|
@BrennanConroy Can I get your sign-off on this backport? |
| } | ||
| #nullable restore |
...NetCore.OpenApi.Tests/Transformers/Implementations/OpenApiSchemaReferenceTransformerTests.cs
Outdated
Show resolved
Hide resolved
BrennanConroy
approved these changes
Jan 10, 2025
…rs/Implementations/OpenApiSchemaReferenceTransformerTests.cs
This was referenced Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a set of issues that have been reported with schema reference resolution in the OpenAPI implementation. The crux of the issue deals with the way the underlying System.Text.Json generates relative references for schemas that include recursion or duplication.
Fixes #59677
Fixes #58968
Fixes #59427
Customer Impact
Resolves an issue with re-entrant schemas where no workarounds currently exist.
Regression?
Risk
Low risk because:
Verification
Packaging changes reviewed?