Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport SignalR test changes #46648

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Backport SignalR test changes #46648

merged 2 commits into from
Mar 10, 2023

Conversation

BrennanConroy
Copy link
Member

Backporting a couple test related changes to release/7.0

Tracking test skipped issue #44608

@BrennanConroy BrennanConroy added the tell-mode Indicates a PR which is being merged during tell-mode label Feb 14, 2023
@BrennanConroy BrennanConroy added this to the 7.0.x milestone Feb 14, 2023
@ghost ghost added the area-signalr Includes: SignalR clients and servers label Feb 14, 2023
@ghost
Copy link

ghost commented Feb 14, 2023

Hi @BrennanConroy. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@ghost
Copy link

ghost commented Feb 22, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please remove the pending ci rerun label to kick off a new CI run.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 22, 2023
@wtgodbe
Copy link
Member

wtgodbe commented Mar 9, 2023

I can merge once this has approval

@wtgodbe
Copy link
Member

wtgodbe commented Mar 9, 2023

/azp run

@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Mar 9, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@wtgodbe wtgodbe merged commit 7124b90 into release/7.0 Mar 10, 2023
@wtgodbe wtgodbe deleted the brecon/testskip branch March 10, 2023 19:30
@ghost ghost modified the milestones: 7.0.x, 7.0.5 Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signalr Includes: SignalR clients and servers tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants