[tests] ignore BuildAppCheckDebugSymbols() test on non-commercial builds
#9322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
grendello
added a commit
that referenced
this pull request
Sep 25, 2024
jonathanpeppers
commented
Sep 25, 2024
| @@ -1293,6 +1293,8 @@ public void BuildBasicApplicationCheckPdbRepeatBuild () | |||
| [Test] | |||
| public void BuildAppCheckDebugSymbols () | |||
| { | |||
| AssertCommercialBuild (); // FIXME: when Fast Deployment isn't available, we would need to use `llvm-objcopy` to extract the debug symbols | |||
There was a problem hiding this comment.
Example:
llvm-objcopy --dump-section=payload=payload.bin libassemblies.arm64-v8a.blob.so
jonathanpeppers
changed the title
BuildAppCheckDebugSymbols() testBuildAppCheckDebugSymbols() test on non-commercial builds
grendello
approved these changes
Sep 25, 2024
|
There is a network failure we can ignore: But going to merge, so this can unblock other PRs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10272296&view=ms.vss-test-web.build-test-results-tab&runId=111431847&resultId=100127&paneView=debug
With Fast Dev disabled, this test fails with:
We can eventually fix the test, but we'd have to shell out to: