Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace IdentityServer4 with Duende.IdentityServer (#3008) #3184

Conversation

pseudometalhead
Copy link
Contributor

@pseudometalhead pseudometalhead commented Dec 2, 2024

Pull Request

Fixes #3008

The issue or feature being addressed

This PR replaces IdentityServer4 with Duende.IdentityServer.

Details on the issue fix or feature implementation

  • Replaced IdentityServer4 with Duende.IdentityServer in project dependencies.
  • Updated the OAuth2Integration code to be compatible with Duende.IdentityServer.
  • Verified that all existing integration tests are passing.

@pseudometalhead pseudometalhead force-pushed the replace-usage-of-IdentityServer4-in-integrationtests branch from 2551c56 to 8596545 Compare December 2, 2024 22:34
Copy link
Collaborator

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor comments - thanks for picking this up!

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.58%. Comparing base (164b910) to head (74325e4).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3184   +/-   ##
=======================================
  Coverage   83.58%   83.58%           
=======================================
  Files          76       76           
  Lines        3161     3161           
  Branches      536      536           
=======================================
  Hits         2642     2642           
  Misses        519      519           
Flag Coverage Δ
Linux 83.58% <ø> (ø)
Windows 83.58% <ø> (ø)
macOS 83.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 6873e65 into domaindrivendev:master Jan 21, 2025
9 checks passed
Saibamen added a commit to Saibamen/Swashbuckle.AspNetCore that referenced this pull request Jan 21, 2025
martincostello pushed a commit that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Replace usage of IdentityServer4 in tests
3 participants