Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid exception checking nullability #3119

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

martincostello
Copy link
Collaborator

  • Do not throw if we cannot determine the nullability of a dictionary. It's better to potentially be wrong, rather than be unable to generate a document at all.
  • Clean-up some code analysis suggestions.

Resolves #3070.
Resolves #2793 (as it's the last linked issue).

- Do not throw if we cannot determine the nullability of a dictionary.
- Clean-up some code analysis suggestions.

Resolves domaindrivendev#3070.
Resolves domaindrivendev#2793.
@martincostello martincostello enabled auto-merge (rebase) October 25, 2024 11:38
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.44%. Comparing base (da07a53) to head (2a14a3e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3119      +/-   ##
==========================================
- Coverage   91.43%   89.44%   -2.00%     
==========================================
  Files          76       97      +21     
  Lines        3119     3523     +404     
  Branches      519      627     +108     
==========================================
+ Hits         2852     3151     +299     
- Misses        267      372     +105     
Flag Coverage Δ
Linux 91.60% <100.00%> (+0.16%) ⬆️
Windows 89.37% <100.00%> (-2.07%) ⬇️
macOS 91.60% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mesMess mesMess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code cleanup
Changing to concrete types (in-code) over var 👍🏼
Nullability exception check fix

@martincostello martincostello merged commit 00890c9 into domaindrivendev:master Nov 23, 2024
9 checks passed
@martincostello martincostello deleted the gh-3070 branch November 23, 2024 22:43
@martincostello martincostello added this to the v7.0.1 milestone Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants