Allow parsing of CREATE TABLE t AS (...) UNION (...)
#277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktobey
force-pushed
the
nicktobey/createas
branch
from
e3da64c to
5d27de3
Compare
fulghum
reviewed
Sep 28, 2023
go/vt/sqlparser/out.txt
Outdated
There was a problem hiding this comment.
Was this file meant to be added? I didn't look at the contents yet, but the name sounded suspicious 😉
There was a problem hiding this comment.
Whoops! That's the debug output from yacc. It shouldn't be there.
nicktobey
force-pushed
the
nicktobey/createas
branch
from
5d27de3 to
5b302d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows parsing of
CREATE TABLE ASstatements when the expression being used to create the table is a set operation like UNION, INTERSECT, or EXCEPT.The "AS" keyword is typically optional. But this change only allows set ops to be used with CREATE ... AS when the AS is explicit. This is to avoid an ambiguity in the current grammar when attempting to parse
CREATE TABLE t (, where what follows could be a set op or a table definition. Fully matching MySQL's spec here would require rewriting our grammar to avoid this ambiguity, which is outside the scope of the PR. However, this PR makes us strictly more correct than we were before.