Add several features that unblock mysql workbench #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinaiRachakonda
changed the title
zachmu
approved these changes
Sep 30, 2021
sql/parse/parse.go
Outdated
| @@ -346,6 +346,34 @@ func convertSet(ctx *sql.Context, n *sqlparser.Set) (sql.Node, error) { | |||
| }) | |||
| } | |||
|
|
|||
| // Special case: SET CHARACTER SET (CHARSET) expands to 3 different system variables. Although we do not support very | |||
| // many character sets, changing these variables should not have any affect currently as our character set support is | |||
| "github.com/dolthub/go-mysql-server/sql" | ||
| ) | ||
|
|
||
| type ShowStatus struct { |
There was a problem hiding this comment.
Type comment
And note that it's a stub implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr implements