Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISNULL(expr) and compatible with Navicat Premium #418

Merged
merged 2 commits into from
May 17, 2021

Conversation

iineva
Copy link
Contributor

@iineva iineva commented May 15, 2021

When I use Navicat Premium 15.0.28 to design tables.

Get error: 1105 - function: 'isnull, maybe you mean ifnull?' not found

After I implement ISNULL(expr).

Get error: 1105 - column "PARTITION_DESCRIPTION" could not be found in any table in scope

This RP is fixed this problem.

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Looks good, just one small change

@@ -419,6 +419,7 @@ var partitionSchema = Schema{
{Name: "partition_expression", Type: MustCreateStringWithDefaults(sqltypes.VarChar, 2048), Default: nil, Nullable: true, Source: PartitionsTableName},
{Name: "subpartition_expression", Type: MustCreateStringWithDefaults(sqltypes.VarChar, 2048), Default: nil, Nullable: true, Source: PartitionsTableName},
{Name: "partition_descriptor", Type: LongText, Default: nil, Nullable: true, Source: PartitionsTableName},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually just a typo: there is no partition_descriptor column, just the one you added.

@iineva
Copy link
Contributor Author

iineva commented May 16, 2021

@zachmu Deleted partition_descriptor.

@zachmu zachmu merged commit 2914f74 into dolthub:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants