Fixed system variables #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
approved these changes
Apr 23, 2021
There was a problem hiding this comment.
This looks very good, nice work.
The only thing this is missing is more extensive tests. Specifically I want tests that guarantee that user / session / global vars can all have distinct values with the same name. You have a bit of that in enginetests.go, but only for global / session, not any user vars.
Otherwise looks great
Hydrocharged
force-pushed
the
daylon/vars-2
branch
from
f6075ae to
d84f0c8
Compare
Hydrocharged
force-pushed
the
daylon/vars-2
branch
from
d84f0c8 to
536e817
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.