support DECLARE in BEGIN...END BLOCK in TRIGGER
#2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
approved these changes
Apr 11, 2024
max-hoffman
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to use
DECLAREstatements inTRIGGERS.The analyzer rule
applyTriggerswas altered to initializeProcedureReferenceforTriggerBeginEndBlock.The important part was ensuring that all relevant nodes (
TriggerBeingEndBlock,BeginEndBlock,ProcedureParam) all had the sameProcedureReferenceand to search in all the nodes.Additionally,
nilguards are added to all receiver methods forProcedureReferenceto prevent panics.It seems like events might have this issue, but there's a banaid fix for it. Not sure if I want to touch that code.
fixes: dolthub/dolt#7720