[stats] costed index scan perf #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
approved these changes
Apr 2, 2024
sql/stats/filter.go
Outdated
| func Union(s1, s2 sql.Statistic) sql.Statistic { | ||
| return s1 | ||
| func Union(b1, b2 []sql.HistogramBucket, types []sql.Type) ([]sql.HistogramBucket, error) { | ||
| var ret []sql.HistogramBucket |
There was a problem hiding this comment.
Might want to allocate the full potential capacity here to avoid a bunch of mallocs during the loop
| func Intersect(s1, s2 sql.Statistic) sql.Statistic { | ||
| return s1 | ||
| func Intersect(b1, b2 []sql.HistogramBucket, types []sql.Type) ([]sql.HistogramBucket, error) { | ||
| var ret []sql.HistogramBucket |
There was a problem hiding this comment.
Same comment about allocations. Could also consider a pool.
There was a problem hiding this comment.
if it starts to show up on profiles again i can add a pool, so far sysbench and tpc-c don't seem to execute this a lot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Histogram copying is expensive. Instead pass and mutate references. We have to use a different struct type to load stats from JSON in order to support histogram interface generalization.
related Dolt-side: dolthub/dolt#7666