Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement json_search() #2411

Merged
merged 15 commits into from
Mar 25, 2024
Merged

implement json_search() #2411

merged 15 commits into from
Mar 25, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Mar 25, 2024

fulghum
fulghum approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Biggest thing I noticed was that it looks like MySQL allows multiple paths to be specified. Good job covering all the test cases.

enginetest/queries/queries.go Outdated Show resolved Hide resolved
sql/expression/function/json/json_search.go Outdated Show resolved Hide resolved
sql/expression/function/json/json_search.go Show resolved Hide resolved
@jycor jycor merged commit 1765430 into main Mar 25, 2024
7 checks passed
@jycor jycor deleted the james/search branch March 25, 2024 22:38
@BrewTestBot BrewTestBot mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jycor @fulghum