Adding system variable innodb_autoinc_lock_mode
#2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
approved these changes
Mar 22, 2024
max-hoffman
reviewed
Mar 22, 2024
|
|
||
| for _, test := range tests { | ||
| t.Run(fmt.Sprintf("set %v = %v", test.varName, test.varVal), func(t *testing.T) { | ||
| InitSystemVariables() |
There was a problem hiding this comment.
maybe defer the call to make sure it resets if something errors?
added 2 commits
March 22, 2024 14:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently only support
innodb_autoinc_lock_mode = 2, not0or1.MySQL Docs:
https://dev.mysql.com/doc/refman/8.0/en/innodb-auto-increment-handling.html
related: dolthub/dolt#7634