Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix decimal result scale difference on server #2194

Merged
merged 7 commits into from
Dec 13, 2023
Merged

fix decimal result scale difference on server #2194

merged 7 commits into from
Dec 13, 2023

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented Dec 8, 2023 •
edited
Loading

This PR fixes:

  • converting the decimal type values to given decimal column type before inserting.
  • getting precision and scale of final decimal type correctly.

@jennifersp jennifersp marked this pull request as ready for review December 12, 2023 21:39
@jennifersp jennifersp requested a review from fulghum December 12, 2023 21:39
fulghum
fulghum approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I love seeing us turn on more tests for the server engine! 🙌

@jennifersp jennifersp merged commit 47a48c5 into main Dec 13, 2023
7 checks passed
@jennifersp jennifersp deleted the jennifer/decimal branch December 13, 2023 20:14
@BrewTestBot BrewTestBot mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennifersp @fulghum