Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReferenceChecker interface #2132

Merged
merged 1 commit into from
Nov 7, 2023
Merged

ReferenceChecker interface #2132

merged 1 commit into from
Nov 7, 2023

Conversation

max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented Nov 7, 2023 •
edited
Loading

re: dolthub/dolt#6957 It is expensive and unnecessary to deserialize blobs during FK reference check lookups.

zachmu
zachmu approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

@max-hoffman max-hoffman merged commit 99ca3db into main Nov 7, 2023
7 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 7, 2023
Merged
@Hydrocharged Hydrocharged deleted the max/ref-check-interface branch February 7, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-hoffman @zachmu