Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support json_valid() function #2072

Merged
merged 5 commits into from
Oct 12, 2023
Merged

support json_valid() function #2072

merged 5 commits into from
Oct 12, 2023

Conversation

jennifersp
Copy link
Contributor

Add support for JSON_VALID(val) function

@jennifersp jennifersp requested a review from macneale4 October 12, 2023 20:23
macneale4
macneale4 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@macneale4 macneale4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One additional test required, then ship it!

sql/expression/function/json/json_valid_test.go Show resolved Hide resolved
@macneale4
Copy link
Contributor

Dolt Issue: dolthub/dolt#6808

@jennifersp jennifersp merged commit c90c89b into main Oct 12, 2023
@jennifersp jennifersp linked an issue Oct 12, 2023 that may be closed by this pull request
Support JSON_VALID() dolthub/dolt#6808
Closed
@jennifersp jennifersp deleted the jennifer/json-valid branch October 12, 2023 20:59
@BrewTestBot BrewTestBot mentioned this pull request Oct 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macneale4 macneale4 macneale4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support JSON_VALID()
2 participants
@jennifersp @macneale4