Trigger view errors don't prevent writes on database with preexisting trigger views #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jycor
approved these changes
Oct 2, 2023
| @@ -565,8 +565,8 @@ var ( | |||
| // ErrViewsNotSupported is returned when attempting to access a view on a database that doesn't support them. | |||
| ErrViewsNotSupported = errors.NewKind("database '%s' doesn't support views") | |||
|
|
|||
| // ErrNotBaseTable is returned when attempting to rename a view using ALTER TABLE statement. | |||
| ErrNotBaseTable = errors.NewKind("'%s' is not BASE TABLE") | |||
There was a problem hiding this comment.
This is the error MySQL throws, but it isn't that descriptive.
|
thanks for the reviews, sending |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2034 made it so that we can not DDL triggers on views. But past versions of Dolt permitted creating those triggers. After this change, databases with a trigger view will be have all writes blocked with the trigger view error. We should probably not try to parse and bind all triggers for every write, but as long as we do this adds a warning rather than an error for a non-DDL trigger parse.