Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not error for SHOW view indexes #2026

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Do not error for SHOW view indexes #2026

merged 1 commit into from
Sep 22, 2023

Conversation

max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented Sep 22, 2023 •
edited
Loading

Until we support view indexes, return nil for show view keys/indexes.

fixes dolthub/dolt#6705

zachmu
zachmu approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@max-hoffman max-hoffman merged commit ea6de8a into main Sep 22, 2023
@max-hoffman max-hoffman deleted the max/show-view-indexes branch September 22, 2023 20:03
@ZhongRuoyu ZhongRuoyu mentioned this pull request Sep 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SHOW KEYS FROM only works for views
2 participants
@max-hoffman @zachmu