Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: Make ReadOnly a toggleable atomic.Bool. #1961

Merged
merged 2 commits into from
Aug 22, 2023
Merged

engine: Make ReadOnly a toggleable atomic.Bool. #1961

merged 2 commits into from
Aug 22, 2023

Conversation

reltuk
Copy link
Contributor

@reltuk reltuk commented Aug 22, 2023

No description provided.

@reltuk reltuk requested a review from max-hoffman August 22, 2023 20:46
max-hoffman
max-hoffman approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one perf Q

engine.go Outdated Show resolved Hide resolved
max-hoffman
max-hoffman approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm, i was meaning to switch that check anyways because this rule shows up on profiles, thanks for saving me the time

@reltuk reltuk merged commit 6fe6d0c into main Aug 22, 2023
@Hydrocharged Hydrocharged deleted the aaron/readonly-engine-updates branch August 24, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reltuk @max-hoffman