Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude procedure aliases from showing information_schema.routines table #1042

Merged
merged 1 commit into from
Jun 6, 2022
Merged

exclude procedure aliases from showing information_schema.routines table #1042

merged 1 commit into from
Jun 6, 2022

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented Jun 6, 2022 •
edited
Loading

Not show procedure aliases in information_schema.routines table
Dolt PR tests this change

@jennifersp jennifersp requested a review from timsehn June 6, 2022 23:31
@jennifersp jennifersp mentioned this pull request Jun 6, 2022
Merged
timsehn
timsehn reviewed Jun 6, 2022
View reviewed changes
Copy link
Contributor

@timsehn timsehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a test that makes sure one of the aliases isn't there? It can be engine. Does not need to be bats.

@timsehn
Copy link
Contributor

timsehn commented Jun 6, 2022

Saw tests in the other.

timsehn
timsehn approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@timsehn timsehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jennifersp jennifersp merged commit 326ad6f into main Jun 6, 2022
@jennifersp jennifersp deleted the jennifer/proc-alias branch June 6, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timsehn timsehn timsehn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennifersp @timsehn