Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup enginetest #1041

Merged
merged 6 commits into from
Jun 7, 2022
Merged

cleanup enginetest #1041

merged 6 commits into from
Jun 7, 2022

Conversation

andy-wm-arthur
Copy link
Contributor

Splits up enginetest/enginetest.go into initialization.go and evaluation.go. The intent is to leave only test banks in enginetest.go

This is a pure refactor, no logical changes were made.

@andy-wm-arthur andy-wm-arthur requested a review from zachmu June 6, 2022 23:46
@andy-wm-arthur andy-wm-arthur marked this pull request as ready for review June 7, 2022 15:58
zachmu
zachmu approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice cleanup

@andy-wm-arthur andy-wm-arthur merged commit dfd8f9b into main Jun 7, 2022
@andy-wm-arthur andy-wm-arthur deleted the andy/cleanup-enginetest branch June 7, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy-wm-arthur @zachmu