Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some column values of information_schema.columns table #1029

Merged
merged 6 commits into from
May 24, 2022
Merged

fix some column values of information_schema.columns table #1029

merged 6 commits into from
May 24, 2022

Conversation

jennifersp
Copy link
Contributor

Fixes column_key, character_maximum_length, data_type and column_type column values of information_schema.columns table

@jennifersp jennifersp requested a review from fulghum May 24, 2022 19:17
fulghum
fulghum approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think I found one edge case for you to double-check and other than that, I just had some minor suggestions. Good job knocking this one out quickly! 💥

sql/information_schema/columns_table.go Show resolved Hide resolved
sql/information_schema/information_schema.go Outdated Show resolved Hide resolved
enginetest/queries/queries.go Outdated Show resolved Hide resolved
sql/information_schema/columns_table.go Show resolved Hide resolved
sql/information_schema/columns_table.go Outdated Show resolved Hide resolved
sql/information_schema/columns_table.go Outdated Show resolved Hide resolved
@jennifersp jennifersp merged commit 6befa5d into main May 24, 2022
@jennifersp jennifersp deleted the jennifer/columns branch May 24, 2022 21:38
@jennifersp jennifersp mentioned this pull request May 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennifersp @fulghum