Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing "DEFAULT NULL" for blob column definitions #1005

Merged
merged 2 commits into from
May 11, 2022
Merged

Allowing "DEFAULT NULL" for blob column definitions #1005

merged 2 commits into from
May 11, 2022

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented May 11, 2022

@fulghum fulghum requested review from zachmu and removed request for zachmu May 11, 2022 00:45
@fulghum fulghum requested a review from zachmu May 11, 2022 01:02
zachmu
zachmu approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fulghum fulghum merged commit ddabb4a into main May 11, 2022
@fulghum fulghum deleted the fulghum/dolt-3388 branch May 11, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

text/blob types may only have expression default values
2 participants
@fulghum @zachmu