support (IN)VISIBLE index feature

[0x4261756D]

There is no support for the VISIBLE and INVISIBLE keywords for indexes.
This is especially bothering since MySQL Workbench always adds one of those keywords when creating an index via the GUI.
Steps to reproduce:

 CREATE TABLE `dolt_test`.`a` (`id` INT, `b` DOUBLE, PRIMARY KEY (`id`), INDEX `c` (`b` ASC) INVISIBLE);

produces

syntax error at position 102 near 'INVISIBLE'
CREATE TABLE `dolt_test`.`a` (`id` INT, `b` DOUBLE, PRIMARY KEY (`id`), INDEX `c` (`b` ASC) INVISIBLE)

[fulghum]

Hey @0x4261756D, thanks for reporting this gap! 🙏 Adding syntax support for this (i.e. parsing, but treating it as a no-op) should be pretty easy. I'm wrapping up some testing on another task, then I'll jump on to this and see if I can get our grammar updated to allow this syntax. Stay tuned!

[fulghum]

The changes to the parser to support this syntax were merged in. Once a few more CI steps complete, I'll be able to cut a release and will let you know when the fix is available to pick up.

[fulghum]

@0x4261756D – This fix is now available in Dolt 1.16.2.

Thank you for taking the time to file this issue so we could get this fixed! 🙏 Let us know if you run into any other problems with Dolt and we'll be happy to jump on them.