-
Notifications
You must be signed in to change notification settings - Fork 89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Stoked on this feature. Could you please also add a flag to the cli that allows the user to specify the path to persist the KeyValueStore? It should be empty by default which should indicate that persistence is off.
Hey @hankjacobs - added features as requested. I've added the flag I've added the flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Just some minor changes but overall looks good.
Oh and don't forget to update with master |
All patched and optimised now :) |
All resolved now - this should be it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes so close, just one more I think :)
Yes, corrected now! |
Merged and beta pushed with it included. I'll play with it tomorrow and publish a new version if it looks good. |
Excellent - thank you! |
@larkin-nz v0.0.11 has been released |
Excellent - thank you! |
Hey @hankjacobs,
I've added support for persistence via the API for the
KeyValueStore
.When it is called with a
path
passed to the constructor it will create a file using the path specified.Example usage:
I've added a test also so you can validate it all works correctly.
I'd also appreciate it if you could release it in a new release on NPM as soon as possible as I'd like to be using this functionality with Restt-CLI.
Keep up the great work :)