lang: semantic tests #949
lang: semantic tests #949
Conversation
shramee
force-pushed
the
semantic-tests
branch
from
3516dbb to
654483b
Compare
| //! > semantic_diagnostics | ||
| error: Identifier not found. | ||
| --> get_inline_macro:2:96 | ||
| let mut __get_macro_keys__ = array::ArrayTrait::new();serde::Serde::serialize(@key, ref __get_macro_keys__); |
There was a problem hiding this comment.
Can we improve formatting here? i.e. new line. I guess it's not possible to define key / suppress this? It adds noise to the test
There was a problem hiding this comment.
It's just showing the whole line where stuff happens. I think most straightforward is to add some line breaks in macro expansion. Which is what I've done in the latest commit 😉
shramee
force-pushed
the
semantic-tests
branch
from
d7023eb to
23e568e
Compare
with concise diagnostics
shramee
force-pushed
the
semantic-tests
branch
from
23e568e to
f2ee50c
Compare
| //! > semantic_diagnostics | ||
| error: Identifier not found. | ||
| --> get_inline_macro:3:26 | ||
| serde::Serde::serialize(@key, ref __get_macro_keys__); |
There was a problem hiding this comment.
If we add key and world to setup and intern dojo-core in the semantic db i think these diagnostics will go away
There was a problem hiding this comment.
Aah, I misunderstood...
Yeah, I can look into it.
There was a problem hiding this comment.
To get rid of all diagnostic, we actually need the whole dojo crate to have it work.
Or mock stuff we need.
Semantic tests for set! and get! macros.
#924