Refactor(torii-core): Optimize and clean sql statements #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! there are some sizable changes coming down the pipe (#916), I think we could wait for this one to land first. Also we're gonna be moving to |
|
Reopening for @gianalarcon now that nested model is implemented |
|
Ready for review! |
tarrencev
approved these changes
Oct 25, 2023
| )); | ||
| ); | ||
| // execute first to get created_at | ||
| let query_result: SqliteRow = sqlx::query(&insert_entities).fetch_one(&self.pool).await?; |
There was a problem hiding this comment.
Can you use query_as here?
There was a problem hiding this comment.
Merging. Feel free to follow up with the change
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor fn register_model(), and fn set_entity() to get rid of extra SQL query statements.
Solution
Use RETURNING clause to avoid unnecessary SQL statements