feat(torii): index events #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broody
force-pushed
the
torii-index-events
branch
from
4868671 to
12003c7
Compare
tarrencev
reviewed
Sep 17, 2023
| @@ -70,12 +70,11 @@ CREATE INDEX idx_entities_keys ON entities (keys); | |||
| CREATE INDEX idx_entities_keys_create_on ON entities (keys, created_at); | |||
|
|
|||
| CREATE TABLE events ( | |||
| id TEXT NOT NULL PRIMARY KEY, | |||
| system_call_id INTEGER NOT NULL, | |||
| id INTEGER PRIMARY KEY AUTOINCREMENT, | |||
There was a problem hiding this comment.
i think we will want this to be a computed value, so we can use upserts to make indexing idempotent. something like block_id:event_idx (in ethereum, event index is relative to the block it is included in). afaik starknet doesn't currently have unique event id's but I assume they will follow ethereums approach
There was a problem hiding this comment.
Gotcha, I've used the event_idx relative to tx receipt for now and so computed id is tx_hash:event_idx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll remove the state redirection in another PR, enabling this so we can start retrieving events from graphql