Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support component packing #877

Merged
merged 11 commits into from
Sep 19, 2023
Merged

Support component packing #877

merged 11 commits into from
Sep 19, 2023

Conversation

tarrencev
Copy link
Contributor

No description provided.

@tarrencev tarrencev force-pushed the packing branch 6 times, most recently from cc315ae to 1330c7c Compare September 8, 2023 17:16
@tarrencev tarrencev marked this pull request as ready for review September 8, 2023 17:17
@tarrencev tarrencev force-pushed the packing branch 5 times, most recently from 8355a1a to bde37eb Compare September 8, 2023 21:24
@neotheprogramist
Copy link
Collaborator

The error messages points the problem with deserialization.
While running test there appears such kinds of error messages:

  • Supply failed to deserialize
  • Uri failed to deserialize
    That suggested problem with felt252 deserialization

I was able to solve that by changing StorageLayoutFelt252 accordingly

impl StorageLayoutFelt252 of StorageLayout<felt252> {
    #[inline(always)]
    fn size() -> usize {
        2
    }

    #[inline(always)]
    fn layout(ref layout: Array<u8>) {
        layout.append(126);
        layout.append(126);
    }
}

Now instead of 66 failing tests, we have 58 failing.

The error messages changed as well, now they suggest deserialization problem with u256 and address

  • ERC1155Balance failed to deseri(alize)
  • ERC721Owner failed to deseriali(ze)
    But unfortunately, that seems to be (de)serialized well.
    I will try to find what causes that problem.

@tarrencev tarrencev force-pushed the packing branch 8 times, most recently from e26f097 to 00327ac Compare September 15, 2023 13:50
@tarrencev tarrencev force-pushed the packing branch 3 times, most recently from e4a874b to 45d4b93 Compare September 19, 2023 18:52
@tarrencev tarrencev merged commit be80741 into main Sep 19, 2023
@tarrencev tarrencev deleted the packing branch September 19, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants