-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support component packing #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrencev
force-pushed
the
packing
branch
6 times, most recently
from
September 8, 2023 17:16
cc315ae
to
1330c7c
Compare
tarrencev
force-pushed
the
packing
branch
5 times, most recently
from
September 8, 2023 21:24
8355a1a
to
bde37eb
Compare
The error messages points the problem with deserialization.
I was able to solve that by changing StorageLayoutFelt252 accordingly impl StorageLayoutFelt252 of StorageLayout<felt252> {
#[inline(always)]
fn size() -> usize {
2
}
#[inline(always)]
fn layout(ref layout: Array<u8>) {
layout.append(126);
layout.append(126);
}
} Now instead of 66 failing tests, we have 58 failing. The error messages changed as well, now they suggest deserialization problem with
|
tarrencev
force-pushed
the
packing
branch
8 times, most recently
from
September 15, 2023 13:50
e26f097
to
00327ac
Compare
tarrencev
force-pushed
the
packing
branch
3 times, most recently
from
September 19, 2023 18:52
e4a874b
to
45d4b93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.