feat(torii): enum support #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broody
commented
Sep 7, 2023
| Down: (), | ||
| } | ||
|
|
||
| impl DirectionPrintImpl of PrintTrait<Direction> { |
There was a problem hiding this comment.
For some reason, running sozo test something is forcing debug print of all component members so needed to implement PrintTrait, otherwise can be removed
There was a problem hiding this comment.
Hmm I'll take a look at this
tarrencev
approved these changes
Sep 8, 2023
|
|
||
| let position_component = world.component("Position", block_id).await.unwrap(); | ||
|
|
||
| let position = position_component.entity(vec![account.address()], block_id).await.unwrap(); | ||
|
|
||
| assert_eq!(position, vec![11_u8.into(), 11_u8.into()]); | ||
| assert_eq!(position, vec![9_u8.into(), 9_u8.into()]); |
There was a problem hiding this comment.
Added a None state to the Direction enum so it shifted the cmds up by one
| Down: (), | ||
| } | ||
|
|
||
| impl DirectionPrintImpl of PrintTrait<Direction> { |
There was a problem hiding this comment.
Hmm I'll take a look at this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #772
Currently, indexer can't differentiate between enums and custom type in component members, so unknown types will default to enum. Will requires a bigger followup PR to support custom types