ERC auth / fix / tests #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
notV4l
commented
Aug 26, 2023
•
notV4l
commented
- configure writer rights for components/systems
- changes on update( in erc1155 & add tests for erc1155 with zero address
- add tests for erc1155 events
- add tests for erc1155 burn
- prefix unckecked_ for fn requiring safety checks before calling
- modify ERC1155Balance component to respect token/account/id order
tarrencev
approved these changes
Aug 30, 2023
matzayonc
pushed a commit
to visoftsolutions/dojo
that referenced
this pull request
Sep 6, 2023
* configure writer rights for components/systems * scarb fmt * configure writer rights for components/systems * prefix unckecked_ for fn requiring safety checks before calling * fix: ERC1155Balance component to respect token/account/id order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.