-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: derive PrintTrait #721
feat: derive PrintTrait #721
Conversation
2089ef9
to
2321120
Compare
2321120
to
d59a188
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small improvement otherwise lgtm! once we qualify the trait we can remove all the imports (except where we actually use .print()
)
6cbffa5
to
f157e9d
Compare
Thanks for the review @tarrencev ! Unfortunately, I had to remove the error: Plugin diagnostic: Method `print` not found on type "dojo_examples::components::Moves". Did you import the correct trait and impl?
--> inline_macros:55:15
moves.print();
^***^
thread 'compiler::test_compiler' panicked at 'Error compiling: could not compile `dojo_examples` due to previous error', crates/dojo-lang/src/compiler.rs:109:53 |
9494dc9
to
f2086de
Compare
Hello, this pr does the follow
PrintTrait
for a component to print the names and values of the membersPrintTrait
for components #706This is an example of the logging