Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: make DojoMetadata to handle metadata specific to dojo easier #707

Merged
merged 7 commits into from
Aug 5, 2023
Merged

dev: make DojoMetadata to handle metadata specific to dojo easier #707

merged 7 commits into from
Aug 5, 2023

Conversation

lambda-0x
Copy link
Contributor

Fixes: #697

kariy
kariy requested changes Aug 4, 2023
View reviewed changes
crates/sozo/src/commands/options/mod.rs Outdated Show resolved Hide resolved
crates/sozo/src/commands/options/mod.rs Outdated Show resolved Hide resolved
crates/sozo/src/commands/options/mod.rs Outdated Show resolved Hide resolved
crates/sozo/src/commands/options/mod.rs Show resolved Hide resolved
crates/sozo/src/commands/options/mod.rs Outdated Show resolved Hide resolved
@kariy
Copy link
Member

kariy commented Aug 4, 2023

lets also add some tests to check that we can properly deserialize the toml::Value into DojoMetadata

@lambda-0x
Copy link
Contributor Author

( formatting scripts are running for me without any changes, not sure why its failing here )

@lambda-0x lambda-0x requested a review from kariy August 4, 2023 17:31
@kariy kariy merged commit a2ccbde into dojoengine:main Aug 5, 2023
@lambda-0x lambda-0x deleted the fix-697 branch August 7, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kariy kariy kariy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend Scarb manifest for extracting Dojo metadata
2 participants
@lambda-0x @kariy