-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Cairo 2.1.0 #675
Conversation
49eb9a4
to
75fdb33
Compare
@@ -188,10 +188,10 @@ fn convert_deploy_account_to_rpc_tx( | |||
fn convert_invoke_to_rpc_tx(transaction: ApiInvokeTransaction) -> InvokeTransaction { | |||
match transaction { | |||
ApiInvokeTransaction::V0(tx) => InvokeTransaction::V0(InvokeTransactionV0 { | |||
nonce: tx.nonce.0.into(), | |||
nonce: FieldElement::ZERO, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kariy need to update this
* Return when the target path already exists * Add packages to compile
Updates
Now it's building, but 2 tests are failing,
thread 'contract::component::test::test_component' panicked at
assertion failed: `(left == right)`
left: `FieldElement { inner: 0x02da8fb6056624dd6fa7070497350a13914a21e2a53f171271f72721c5448912 }`,
right: `FieldElement { inner: 0x042e9aac8d3d6e6185815f891a5fa3b442e86e2bef3bca3ac620744309af7fe7 }`,
in crates/dojo-client/src/contract/component_test.rs:28:5
thread 'contract::system::test::test_system' panicked at
called `Result::unwrap()` on an `Err` value:
ReaderError(ContractReaderError(ProviderError(StarknetError(ContractError)))),
in crates/dojo-client/src/contract/system_test.rs:27:59 |
For #675 Makes sense for class hash to be changed coz compiled code is now different.
For failure 1, that is expected since the bytecode changed. We can update the expected class hash to match the new output |
btw seems like the cargo fmt --check --all -- "$@" |
Aye, after fixing that, it seems like
And
Aah, perhaps I'm on nightly, it seemed to work for me. |
Ah yes, we've removed the schema method for now. We should update the logic to not use it. It was a naive implantation anyways and assumed one slot per member |
Edited the message above with newer deets. I'll catch up later! |
@tarrencev whats the reason for removing the |
29ccca4
to
ce6bdb2
Compare
The way that we were extracting dependencies was creating syntactical constraints, it's the reason we always needed to pass a struct constructor to set, so I removed it for now. We'll add it back in the future. |
Resolves #559 #664