Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

492 update block timestamp #504

Merged
merged 7 commits into from
Jun 20, 2023
Merged

492 update block timestamp #504

merged 7 commits into from
Jun 20, 2023

Conversation

aymericdelab
Copy link
Contributor

@aymericdelab aymericdelab commented Jun 14, 2023 •
edited by kariy
Loading

Resolves #492

Features

  • set block timestamp
  • increase block timestamp
  • get block timestamp

I've followed the same logic as in shardlabs devnet implementation which introduces a block info generator
/~https://github.com/0xSpaceShard/starknet-devnet/blob/322b12681ee2a73df01001a6bb144d1ea48790f2/starknet_devnet/block_info_generator.py#L23

@tarrencev tarrencev requested a review from kariy June 14, 2023 13:55
@tarrencev tarrencev requested a review from kariy June 19, 2023 20:20
@tarrencev tarrencev enabled auto-merge (squash) June 19, 2023 20:21
kariy
kariy approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@kariy kariy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tarrencev tarrencev merged commit 4ad1107 into dojoengine:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kariy kariy kariy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Katana] Implement katana_setNextBlockTimestamp
3 participants
@aymericdelab @kariy @tarrencev